Prefer pyproject over setup.py #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PEP 518 and PEP 621. Distutils is also being discontinued so want to always the modern tools. The only thing that doesn't play nicely at the moment is flake8, which wants its configuration in `tox.ini` instead of `pyproject.toml`. But this is also pretty standard, and even used in the sample Python project that PyPa maintain.
|
thanks @fjebaker this is great 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit message for some details.
Basically want to move the setup of
mdbto use the system that PyPa prefers (see e.g. https://github.com/pypa/sampleproject).Nothing practically changes in this PR, as in,
pip install .[develop]and related all still work.